search

apache / logging-log4cxx

Apache Log4cxx is a C++ port of Apache Log4j
http://logging.apache.org/log4cxx
Apache License 2.0
273 stars 122 forks source link

Remove APR pool from Logger constructor in next ABI version #392

Closed swebb2066 closed 3 months ago

swebb2066 commented 3 months ago

No memory pool should live as long as a Log4cxx logger.

rm5248 commented 3 months ago

Would it make sense to create a new branch(e.g. log4cxx-next or something like that) to do this type of refactoring in? It might make it a bit cleaner rather than having a bunch of #if in the code.

swebb2066 commented 3 months ago

Would it make sense to create a new branch

On reflection, I am now inclined to add new methods in 1.3 and generate deprecated warnings on the functions to be removed in the next ABI.