search

apache / logging-log4j-kotlin

A Kotlin-friendly interface to log against the Log4j API
https://logging.apache.org/log4j/kotlin
Apache License 2.0
45 stars 11 forks source link

Kotlin provided scope #17

Closed rocketraman closed 3 years ago

rocketraman commented 3 years ago

Following the discussion in https://github.com/apache/logging-log4j-kotlin/pull/14, I believe the best path forward is to make the Kotlin dependences "provided" dependencies, which should prevent downstream projects from pulling in older versions of Kotlin libs transitively.

However, see the first commit's message -- it scares me a bit because kotlin-reflect and possible the coroutines dependencies may not be on everyone's classpath, and this will cause a runtime failure. I'm not sure what the best approach is but opening this PR for discussion.

jvz commented 3 years ago

Seems like a good idea. Are there CI updates needed here, though? Some build failure.

rocketraman commented 3 years ago

Seems like a good idea. Are there CI updates needed here, though? Some build failure.

Weird I'm not seeing any errors in the build logs, just the abort at the end. Can we try to rebuild it?

jvz commented 3 years ago

If you don't have a "re-run" link on the GitHub Check, then try adding an empty commit or possibly closing then reopening the PR to retrigger CI.

rocketraman commented 3 years ago

@jvz No idea why CI is failing but its not limited to this branch. The other PRs I recently submitted failed with the same non-error.

rocketraman commented 3 years ago

@jvz Not sure what was up with the CI system before, but it seems to be working now. I added a couple of extra commits on this branch.

jvz commented 3 years ago

I'm not blocking you from merging this. Feel free :)