search

apache / logging-log4j-kotlin

A Kotlin-friendly interface to log against the Log4j API
https://logging.apache.org/log4j/kotlin
Apache License 2.0
45 stars 11 forks source link

Add catching and throwing #33

Closed rocketraman closed 1 year ago

rocketraman commented 1 year ago

Closes #32

rocketraman commented 1 year ago

Can you add a changelog entry? Can copy an existing one in https://github.com/apache/logging-log4j-kotlin/tree/master/src/changelog/.1.x.x and reference the issue link there.

I was going to do that but wanted to understand your plans for releasing first so as to give the correct information in the changelog. Your comment makes things clear.

jvz commented 1 year ago

I've been meaning to post that to the dev list, too. Let me sum that up for there since we'll need some reviewers on those releases when they're cut.

rocketraman commented 1 year ago

Changelog added.

jvz commented 1 year ago

That directory gets automatically created when I cut a release; can you put it in the .1.x.x directory? This is a new system recently developed for the main log4j repo.

rocketraman commented 1 year ago

That directory gets automatically created when I cut a release; can you put it in the .1.x.x directory? This is a new system recently developed for the main log4j repo.

Ah, that is much nicer. Done.

jvz commented 1 year ago

Sweet, that's about the last thing needed for 1.3.0 I think! Thanks!