apache / logging-log4j-kotlin

A Kotlin-friendly interface to log against the Log4j API
https://logging.apache.org/log4j/kotlin
Apache License 2.0
45 stars 11 forks source link

Facelift #37

Closed vy closed 9 months ago

vy commented 9 months ago

This facelift operation introduces the following changes

TODO (before merging)

TODO (after merging)

  1. [ ] make a release
  2. [ ] add redirects from logging-log4j-site to this repo
rocketraman commented 9 months ago

@vy As mentioned on Slack, all the spotbugs errors are false positives, as far as I can tell.

vy commented 9 months ago

@vy As mentioned on Slack, all the spotbugs errors are false positives, as far as I can tell.

Fixed in 22ef2028c4c80e1e953516799266a44aa2fd11c5 and d80405a4883b6276767365ddbb2dcb2f4b4e87f3.

vy commented 9 months ago

@rocketraman, thanks so much for the review. And of course I am not gonna merge a PR without green CI checks, in particular, when the PR of subject is supposedly improving the CI. :sweat_smile:

@jvz, we are waiting for your blessing. :innocent:

For the record, I have fixed all ./mvnw clean verify failures and now CI checks pass.