search

apache / logging-log4j-kotlin

A Kotlin-friendly interface to log against the Log4j API
https://logging.apache.org/log4j/kotlin
Apache License 2.0
45 stars 11 forks source link

Restore context correctly #55

Closed rocketraman closed 7 months ago

rocketraman commented 7 months ago

Fixes #54

jvz commented 7 months ago

@rocketraman can you sign your commits? You can use GPG, SSH, or SMIME for that (I use all three in various places).

rocketraman commented 7 months ago

@rocketraman can you sign your commits? You can use GPG, SSH, or SMIME for that (I use all three in various places).

~Yep. Do you want me to rebase this PR with a signed commit, or for the future only?~ Never mind, done.

rocketraman commented 7 months ago

@jvz Is it possible to release a 1.3.1 with this change? I'm using it in a project which extensively uses logging contexts, and without this change, things are royally messed up.

jvz commented 7 months ago

@jvz Is it possible to release a 1.3.1 with this change? I'm using it in a project which extensively uses logging contexts, and without this change, things are royally messed up.

Absolutely! Releases are mostly automated at this point, so let's go find out.

jvz commented 7 months ago

@rocketraman check this out https://logging.apache.org/logging-parent/latest/#release-instructions and see if you can start the release.

rocketraman commented 7 months ago

@rocketraman check this out https://logging.apache.org/logging-parent/latest/#release-instructions and see if you can start the release.

@jvz If I want to do a 1.3.1 release, what is the recommended approach in terms of branches? Create branch release/1.3.1 of off tag rel/1.3.0 and cherry-pick my change into it?

ppkarwasz commented 7 months ago

@rocketraman,

Build #60 failed due to a missing project.build.outputTimestamp property. You should add something like this to the main POM's <properties>:

    <!-- Fixed `project.build.outputTimestamp` is required for reproducible builds: https://maven.apache.org/guides/mini/guide-reproducible-builds.html -->
    <project.build.outputTimestamp>1676697577</project.build.outputTimestamp>

The value of the property does not matter, since the CI should replace it anyway.

If you find other problems in the build or build instructions, please report them to logging-parent.