search

apache / logging-log4net

Apache Log4net is a versatile, feature-rich, efficient logging API and backend for .NET
https://logging.apache.org/log4net
Apache License 2.0
859 stars 327 forks source link

Enable nullable for FileAppender, RollingFileAppender, and unit tests #122

Closed FreeAndNil closed 7 months ago

FreeAndNil commented 7 months ago

For #118 and #124 And fix null issues. Also includes removing reflection code across unit tests for type safety, removing ArrayList usage in favor or strongly typed lists, and a few opportunistic auto-properties and other modernizations. New version of #119 @erikmav I've created a new branch and PR because I couldn't resolve the conflicts in the old one.

erikmav commented 7 months ago

@FreeAndNil I was expanding nullable and strongly typed data structures in the code yesterday. Would it make sense for me to send it along incrementally with new PRs against the 111- branch? Or are you moving fast there and want to minimize interruption?

FreeAndNil commented 7 months ago

@FreeAndNil I was expanding nullable and strongly typed data structures in the code yesterday. Would it make sense for me to send it along incrementally with new PRs against the 111- branch? Or are you moving fast there and want to minimize interruption?

@erikmav your work is very welcome. One remark: we need to have code coverage for the changed blocks. Most blocks are covered but some are not, so adding missing unit tests is needed.