search

apache / logging-log4net

Apache Log4net is a versatile, feature-rich, efficient logging API and backend for .NET
https://logging.apache.org/log4net
Apache License 2.0
849 stars 324 forks source link

Remove obsolete properties, methods, and classes for 3.0 #138

Closed erikmav closed 5 months ago

erikmav commented 5 months ago

Add BinaryFormattter serialize-deserialze testing across versions, and correct serialization property bag names broken by modernization (#124).

Commented out obsolete tag for FixFlags.Mdc as the obsolete tags in MDC.cs are commented out.

erikmav commented 5 months ago

For #125

FreeAndNil commented 1 week ago

@erikmav because of https://learn.microsoft.com/en-us/dotnet/standard/serialization/binaryformatter-security-guide we think about removing ISerializable and [Serializable] (at least for netstandard). What do you think? Where are you using this serialization for log4net objects?

erikmav commented 1 week ago

Unneeded by me. During the 3.0 work it was not clear that serialization could be removed, so I added the newer extensive unit tests including ensuring back compat. Removing it along with all the tests is fine by me.

From: Jan Friedrich @.> Sent: Thursday, September 5, 2024 3:29 PM To: apache/logging-log4net @.> Cc: Erik Mavrinac @.>; Mention @.> Subject: Re: [apache/logging-log4net] Remove obsolete properties, methods, and classes for 3.0 (PR #138)

@erikmavhttps://github.com/erikmav because of https://learn.microsoft.com/en-us/dotnet/standard/serialization/binaryformatter-security-guide we think about removing ISerializable and [Serializable] (at least for netstandard). What do you think? Where are you using this serialization for log4net objects?

— Reply to this email directly, view it on GitHubhttps://github.com/apache/logging-log4net/pull/138#issuecomment-2332739541, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHYCQQIPR2XEAPCGCLDYDLZVDLLLAVCNFSM6AAAAABFNMA7OKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSG4ZTSNJUGE. You are receiving this because you were mentioned.Message ID: @.***>

FreeAndNil commented 1 week ago

@erikmav thanks for your feedback. We have only three failing tests, when removing it. The two from you and PropertiesDictionaryTest. When we remove the old serialization we will maybe switch to DataContractSerializer and adjust the tests.