search

apache / logging-log4net

Apache Log4net is a versatile, feature-rich, efficient logging API and backend for .NET
https://logging.apache.org/log4net
Apache License 2.0
859 stars 327 forks source link

Fix dotnet test Command Not Recognizing NUnit3TestAdapter #164

Closed mobilebilly closed 3 months ago

mobilebilly commented 3 months ago

Fix for Issue #109

This fix addresses the issue where the dotnet test command cannot recognize the NUnit3TestAdapter in existing ItemGroup elements.

Changes Made:

Moved the reference to NUnit3TestAdapter to an ItemGroup without a TargetFramework condition.

FreeAndNil commented 3 months ago

@mobilebilly Thank you very much for your contribution. I retargeted you pull request to Feature/111... because this is our current development branch for 3.0.0. Can you please fix the conflicts and test the changes?

mobilebilly commented 3 months ago

@FreeAndNil , no problem. The conflicts have been fixed, and my branch is now up-to-date with the latest changes from the upstream branch Feature/111.... Please review the updated pull request and let me know if there are any further changes needed.

mobilebilly commented 3 months ago

@FreeAndNil, the additional change in the test project is done. thank you