search

apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.64k stars 1.02k forks source link

extend TopGroups.merge test coverage [LUCENE-9010] #10053

Open asfimport opened 5 years ago

asfimport commented 5 years ago

This sub-task proposes to add test coverage for the TopGroups.merge method, separately from but as preparation for #10039 fixing the 'maxScore is sometimes missing' bug.

edit: converted from #10039 bug-fix sub-task to test-type task of its own so that its life can extend beyond the #10039 bug-fix ticket's life for further test coverage extensions

Migrated from LUCENE-9010 by Christine Poerschke (@cpoerschke), updated Nov 12 2019 Attachments: LUCENE-9010.patch (versions: 2) Linked issues:

asfimport commented 5 years ago

Christine Poerschke (@cpoerschke) (migrated from JIRA)

The attached proposed patch tries to reduce the "amount of numbers" in the test e.g. instead of integer group values 1 and 2 there's string group values "red" and "blue" and a narrative and local variable names (redAntScore, blueDragonflyScore, blueDragonflySize, redSquirrelScore, blueWhaleScore) try to make it easier to work out what the expectedMaxScore value is.

asfimport commented 5 years ago

Lucene/Solr QA (migrated from JIRA)

❌ -1 overall
Vote Subsystem Runtime Comment
Prechecks
+1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
master Compile Tests
+1 compile 1m 10s master passed
Patch Compile Tests
+1 compile 0m 46s the patch passed
-1 javac 0m 46s lucene_grouping generated 4 new + 107 unchanged - 0 fixed = 111 total (was 107)
+1 Release audit (RAT) 0m 46s the patch passed
+1 Check forbidden APIs 0m 46s the patch passed
+1 Validate source patterns 0m 46s the patch passed
Other Tests
+1 unit 1m 3s grouping in the patch passed.
5m 10s
Subsystem Report/Notes
JIRA Issue LUCENE-9010
JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12983203/LUCENE-9010.patch
Optional Tests compile javac unit ratsources checkforbiddenapis validatesourcepatterns
uname Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool ant
Personality /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
git revision master / ebc720c
ant version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018
Default Java LTS
javac https://builds.apache.org/job/PreCommit-LUCENE-Build/210/artifact/out/diff-compile-javac-lucene_grouping.txt
Test Results https://builds.apache.org/job/PreCommit-LUCENE-Build/210/testReport/
modules C: lucene/grouping U: lucene/grouping
Console output https://builds.apache.org/job/PreCommit-LUCENE-Build/210/console
Powered by Apache Yetus 0.7.0 http://yetus.apache.org

This message was automatically generated.

asfimport commented 5 years ago

Lucene/Solr QA (migrated from JIRA)

✔ +1 overall
Vote Subsystem Runtime Comment
Prechecks
+1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
master Compile Tests
+1 compile 0m 21s master passed
Patch Compile Tests
+1 compile 0m 18s the patch passed
+1 javac 0m 18s the patch passed
+1 Release audit (RAT) 0m 18s the patch passed
+1 Check forbidden APIs 0m 18s the patch passed
+1 Validate source patterns 0m 18s the patch passed
Other Tests
+1 unit 0m 17s grouping in the patch passed.
2m 37s
Subsystem Report/Notes
JIRA Issue LUCENE-9010
JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12983268/LUCENE-9010.patch
Optional Tests compile javac unit ratsources checkforbiddenapis validatesourcepatterns
uname Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool ant
Personality /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
git revision master / 63e9bcf
ant version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018
Default Java LTS
Test Results https://builds.apache.org/job/PreCommit-LUCENE-Build/211/testReport/
modules C: lucene/grouping U: lucene/grouping
Console output https://builds.apache.org/job/PreCommit-LUCENE-Build/211/console
Powered by Apache Yetus 0.7.0 http://yetus.apache.org

This message was automatically generated.

asfimport commented 4 years ago

ASF subversion and git services (migrated from JIRA)

Commit f8292f5372502598dc8cabc50642c4f783e1c811 in lucene-solr's branch refs/heads/master from Christine Poerschke https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f8292f5

LUCENE-9010: extend TopGroups.merge test coverage

asfimport commented 4 years ago

ASF subversion and git services (migrated from JIRA)

Commit f8292f5372502598dc8cabc50642c4f783e1c811 in lucene-solr's branch refs/heads/jira/SOLR-13822 from Christine Poerschke https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f8292f5

LUCENE-9010: extend TopGroups.merge test coverage

asfimport commented 4 years ago

ASF subversion and git services (migrated from JIRA)

Commit 516f607618a501596272bbfdcb533277072e485e in lucene-solr's branch refs/heads/branch_8x from Christine Poerschke https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=516f607

LUCENE-9010: extend TopGroups.merge test coverage

asfimport commented 4 years ago

ASF subversion and git services (migrated from JIRA)

Commit 6beac1dc39d3ebadf01335e11f71a19da92a0da3 in lucene-solr's branch refs/heads/branch_8_3 from Christine Poerschke https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6beac1d

LUCENE-9010: extend TopGroups.merge test coverage

asfimport commented 4 years ago

ASF subversion and git services (migrated from JIRA)

Commit 6beac1dc39d3ebadf01335e11f71a19da92a0da3 in lucene-solr's branch refs/heads/jira/SOLR-13101 from Christine Poerschke https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=6beac1d

LUCENE-9010: extend TopGroups.merge test coverage