Remove one of SparseFixedBitSet/DocIdSetBuilder.Buffer [LUCENE-10443]

apache / lucene

Apache Lucene open-source search software

https://lucene.apache.org/

Apache License 2.0

2.69k stars 1.04k forks source link

Remove one of SparseFixedBitSet/DocIdSetBuilder.Buffer [LUCENE-10443] #11479

Open asfimport opened 2 years ago

asfimport commented 2 years ago

SparseFixedBItSet is no longer used by DocIdSetBuilder, but the class didn't get cleaned up and removed.

We only need one sparse representation and don't need to just litter up the codebase with unnecessary classes.

Migrated from LUCENE-10443 by Robert Muir (@rmuir)

shahrs87 commented 2 years ago

SparseFixedBItSet is no longer used by DocIdSetBuilder, but the class didn't get cleaned up and removed.

In main branch, SparseFixedBItSet is used by UnicodeProps, Lucene90OnHeapHnswGraph and DocValuesFieldUpdates. There are more usages in test related code also. @rmuir Are you thinking to replace SparseFixedBItSet with DocIdSetBuilder.Buffer in the above classes ?