BaseVectorSimilarityQueryTestCase assumes connected hnsw graph

apache / lucene

Apache Lucene open-source search software

https://lucene.apache.org/

Apache License 2.0

2.46k stars 979 forks source link

BaseVectorSimilarityQueryTestCase assumes connected hnsw graph #13260

Closed msokolov closed 2 months ago

msokolov commented 3 months ago

…rityQueryTestCase

Description

uschindler commented 3 months ago

I think the Unwrappable for FilterReader should be added in a separate PR. For now this is fine.

I remember vaguely that I left our FilterReader because of the static method conflicting with the interface. This may be a good job for cleanup 10.x (remove static and just implement interface).

msokolov commented 2 months ago

thanks for the reviews!

msokolov commented 2 months ago

hm a failure popped up when I pushed:

org.apache.lucene.search.TestKnnByteVectorQuery > testTimeout FAILED
    java.lang.AssertionError: expected:<1> but was:<0>
        at __randomizedtesting.SeedInfo.seed([AE2970724EFAD848:FE11FBC92B12FA54]:0)

I don't think it's related but I'll check

benwtrent commented 2 months ago

@msokolov I have had something similar fail in other code, so it isn't related to your change here. I think its a flaky test. It doesn't reliably reproduce for me.