search

apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.46k stars 979 forks source link

Convert BooleanClause class to record class #13261

Closed Pulkitg64 closed 2 months ago

Pulkitg64 commented 2 months ago

Description

Convert BooleanClause class to record class which addresses #13207 partially.

jpountz commented 2 months ago

Please add a note to lucene/MIGRATE.txt

By the way, I wonder how we should handle all the classes that we are converting to records, should we have a single section in lucene/MIGRATE.txt that lists all classes for simplicity, instead of having one entry per class?

Pulkitg64 commented 2 months ago

That's a good idea @jpountz. I can add this change under this section: https://github.com/apache/lucene/blob/main/lucene/MIGRATE.md#some-classes-converted-to-records-classes-github13207

uschindler commented 2 months ago

That's a good idea @jpountz. I can add this change under this section: https://github.com/apache/lucene/blob/main/lucene/MIGRATE.md#some-classes-converted-to-records-classes-github13207

That was also my plan. This is why I created the section in the migration guide. No need for separate sections, but a new entry in the enumeration is required.

uschindler commented 2 months ago

The failing test is a known issue (see mailing list). Just ignore that.