apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.45k stars 975 forks source link

Do not use mock merge policy for TestSimilarity #13314

Closed easyice closed 2 months ago

easyice commented 2 months ago

The test relies on the writing order which may be reorder by MockRandomMergePolicy

./gradlew :lucene:core:test --tests "org.apache.lucene.search.TestSimilarity.testSimilarity" -Ptests.seed=120D66F049F980C1 -Ptests.nightly=true
org.apache.lucene.search.TestSimilarity > testSimilarity FAILED
    java.lang.AssertionError: expected:<1.0> but was:<2.0>
        at __randomizedtesting.SeedInfo.seed([120D66F049F980C1:E3A226C8491915DA]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:577)
        at org.junit.Assert.assertEquals(Assert.java:701)
        at org.apache.lucene.search.TestSimilarity$1$1.collect(TestSimilarity.java:100)
        at org.apache.lucene.tests.search.AssertingLeafCollector$AssertingDocIdStream.lambda$forEach$0(AssertingLeafCollector.java:119)
        at org.apache.lucene.tests.search.AssertingLeafCollector$AssertingDocIdStream.lambda$forEach$0(AssertingLeafCollector.java:119)
        at org.apache.lucene.search.BooleanScorer$DocIdStreamView.forEach(BooleanScorer.java:169)
        at org.apache.lucene.tests.search.AssertingLeafCollector$AssertingDocIdStream.forEach(AssertingLeafCollector.java:114)
        at org.apache.lucene.tests.search.AssertingLeafCollector$AssertingDocIdStream.forEach(AssertingLeafCollector.java:114)
        at org.apache.lucene.search.LeafCollector.collect(LeafCollector.java:106)