Harden BaseDocValuesFormatTestCase (#13346)

apache / lucene

Apache Lucene open-source search software

https://lucene.apache.org/

Apache License 2.0

2.45k stars 973 forks source link

Harden BaseDocValuesFormatTestCase (#13346) #13348

Closed dnhatn closed 1 month ago

dnhatn commented 1 month ago

We hit a Codec bug in Elasticsearch, but it went unnoticed because our tests extend from BaseDocValuesFormatTestCase, which doesn't attempt to read the doc-values of the same document twice. This change strengthens BaseDocValuesFormatTestCase checks and randomly inserts that access pattern.