search

apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.45k stars 973 forks source link

Improve BaseRangeFieldQueryTestCase#verify failure output #13382

Open timgrein opened 1 month ago

timgrein commented 1 month ago

Description

While debugging a test case I've noticed that the output on a test failure for BaseRangeFieldQueryTestCase can be slightly improved to understand better what's going on:

Before:

FAIL (iter 0): id=0 should not match but did
 queryRange=Box(...)
 box=Box(...)
 queryType=WITHIN
 deleted?=false

After:

FAIL (iter 0): id=0 should not match but did
 queryRange=Box(...)
 box=Box(...)
 queryType=INTERSECTS
 docDeleted?=false
 rangeMissing?=false

I've changed deleted to docDeleted so it's more explicit what's deleted and also added the info, if a range for a certain document is missing.

github-actions[bot] commented 3 weeks ago

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!