Closed asfimport closed 14 years ago
Shai Erera (@shaie) (migrated from JIRA)
Patch includes the mentioned changes + unit tests. All benchmark tests pass. I think it's ready to commit.
Michael McCandless (@mikemccand) (migrated from JIRA)
I'm hitting a failure here:
[junit] Testcase: testInfoStream_File(org.apache.lucene.benchmark.byTask.tasks.CreateIndexTaskTest): FAILED
[junit] creation of the file should have failed !
[junit] junit.framework.AssertionFailedError: creation of the file should have failed !
[junit] at org.apache.lucene.benchmark.byTask.tasks.CreateIndexTaskTest.testInfoStream_File(CreateIndexTaskTest.java:86)
[junit]
Apparently my OS (currently OpenSolaris 2009.06) has no problem creating a file called "*"... hmm.
Shai Erera (@shaie) (migrated from JIRA)
I was afraid of that ... I think we should just delete that section of the test. If you give an infoStream file which the OS cannot create, you'll get an exception. I see no reason to test for it.
Would you like me to update the patch, or can you just delete this part of the patch if you think it's ready to commit (the last lines of the patch - 587-597)?
Michael McCandless (@mikemccand) (migrated from JIRA)
OK that sounds like a good plan; I'll remove from my area before committing! I plan to commit in a day or two.
Michael McCandless (@mikemccand) (migrated from JIRA)
Thanks Shai!
I would like to add the following support in benchmark:
Patch to come shortly.
Migrated from LUCENE-1716 by Shai Erera (@shaie), resolved Jun 26 2009 Attachments: LUCENE-1716.patch