search

apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.62k stars 1.02k forks source link

validate depends on compile-tools, which does too much [LUCENE-3952] #5025

Closed asfimport closed 12 years ago

asfimport commented 12 years ago

lucene's common-build.xml 'validate' depends on compile-tools, but some modules like icu, kuromoji, etc have a compile-tools target (for other reasons).

I think it should explicitly depend on common.compile-tools instead.

Migrated from LUCENE-3952 by Robert Muir (@rmuir), resolved Apr 04 2012 Attachments: LUCENE-3952.patch

asfimport commented 12 years ago

Robert Muir (@rmuir) (migrated from JIRA)

trivial patch: this placeholder task shouldnt depend on anything, it does nothing.

the top-level tasks are the ones actually invoking license-check-macro.

asfimport commented 12 years ago

Chris M. Hostetter (@hossman) (migrated from JIRA)

with commit r1309556 you can no longer "ant clean compile" from the top level of checkout...

hossman@bester:\~/lucene/dev$ ant clean compile
...
validate:
     [echo] Building spatial...

validate:
     [echo] Building suggest...

validate:
  [taskdef] Could not load definitions from resource lucene-solr.antlib.xml. It could not be found.
     [echo] License check under: /home/hossman/lucene/dev/modules

BUILD FAILED
/home/hossman/lucene/dev/build.xml:68: The following error occurred while executing this line:
/home/hossman/lucene/dev/modules/build.xml:68: The following error occurred while executing this line:
/home/hossman/lucene/dev/lucene/tools/custom-tasks.xml:22: Problem: failed to create task or type licenses
Cause: The name is undefined.
Action: Check the spelling.
Action: Check that any custom tasks/types have been declared.
Action: Check that any <presetdef>/<macrodef> declarations have taken place.

Total time: 14 seconds