search

apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.62k stars 1.02k forks source link

kuromoji ToStringUtil.getRomanization [LUCENE-4433] #5499

Open asfimport opened 12 years ago

asfimport commented 12 years ago

case 'メ': builder.append("mi"); break;

should be case 'メ': builder.append("me"); break;

you can refer http://en.wikipedia.org/wiki/Katakana

Migrated from LUCENE-4433 by Wang Han

asfimport commented 12 years ago

Christian Moen (@cmoen) (migrated from JIRA)

Thanks a lot for this. I'll fix.

asfimport commented 12 years ago

Christian Moen (@cmoen) (migrated from JIRA)

Robert has already fixed this on trunk in r1339753.

asfimport commented 12 years ago

Christian Moen (@cmoen) (migrated from JIRA)

Any thoughts if we should backport this - or just a fix for the specific case mention - to the 3.6 branch, Robert?

I'm happy to do it, but I'm not sure if there will be a 3.6.2 with 4.0 being so close.

asfimport commented 12 years ago

Uwe Schindler (@uschindler) (migrated from JIRA)

but I'm not sure if there will be a 3.6.2 with 4.0 being so close.

As 4.0 is a major change and we still have some bugs in 3.6 and I assume lot's of people cannot upgrade to 4.0 so fast, we should have a 3.6.2 bugfix release some time after 4.0 comes out. I would take care of this.

asfimport commented 12 years ago

Robert Muir (@rmuir) (migrated from JIRA)

I didn't backport this because that at the time, I think this class was only used for debugging. Now its used by at least a tokenfilter.

asfimport commented 12 years ago

Robert Muir (@rmuir) (migrated from JIRA)

Hmm looks like i'm wrong. #4988 was committed in march before i fixed this.

I don't know what I was thinking, sorry.