search

apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.71k stars 1.04k forks source link

SpatialArgsParser should let the context parse the shape string [LUCENE-4444] #5510

Closed asfimport closed 12 years ago

asfimport commented 12 years ago

SpatialArgsParser is not letting the SpatialContext read the shape string (via readShape(); instead it's using new SpatialArgsParser(ctx).readShape(...shapestring...). For the standard SpatialContext there is no difference. But the JTS extension has its own which parses WKT for polygon support, etc.

Quick fix of course but this really sucks if 4.0 won't have the ability to plug in alternative shapes.

Migrated from LUCENE-4444 by David Smiley (@dsmiley), resolved Sep 28 2012 Attachments: LUCENE-4444_Use_SpatialContext_to_read_shape_strings.patch

asfimport commented 12 years ago

David Smiley (@dsmiley) (migrated from JIRA)

Committed to trunk in r1391628 & 4x in r1391629.

asfimport commented 12 years ago

David Smiley (@dsmiley) (migrated from JIRA)

I committed to 4.0 in r1392506 since 4.0 is being re-spun and this is fairly important.

http://lucene.472066.n3.nabble.com/VOTE-release-4-0-take-two-tp4010808p4011255.html

asfimport commented 11 years ago

Commit Tag Bot (migrated from JIRA)

[branch_4x commit] David Wayne Smiley http://svn.apache.org/viewvc?view=revision&revision=1391629

LUCENE-4444 Use SpatialContext to read shape strings. Necessary for supporting 3rd party spatial contexts such as the JTS one to use polygons.

asfimport commented 11 years ago

Uwe Schindler (@uschindler) (migrated from JIRA)

Closed after release.