search

apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.59k stars 1.01k forks source link

LuceneTestFramework fails to catch temporary FieldCache insanity [LUCENE-4954] #6018

Open asfimport opened 11 years ago

asfimport commented 11 years ago

Ever since we added readerClosedListeners to evict FieldCache entries, LTC will no longer detect insanity as long as the test closes all readers leading to insanity ...

So this has weakened our testing of catching accidental insanity producing code.

To fix this I think we could tap into FieldCacheImpl.setInfoStream ... and ensure the test didn't print anything to it.

This was a spinoff from #6017, where that test (AllGroupHeadsCollectorTest) is always producing insanity, but then because of a bug the FC eviction wasn't working right, and LTC then detected the insanity.

Migrated from LUCENE-4954 by Michael McCandless (@mikemccand), updated May 09 2016

asfimport commented 11 years ago

Steven Rowe (@sarowe) (migrated from JIRA)

Bulk move 4.4 issues to 4.5 and 5.0

asfimport commented 10 years ago

Uwe Schindler (@uschindler) (migrated from JIRA)

Move issue to Lucene 4.9.