apache / lucene

Apache Lucene open-source search software

https://lucene.apache.org/

Apache License 2.0

2.59k stars 1.01k forks source link

ShingleAnalyzerWrapper should expose the delegated analyzer as a public final [LUCENE-5406] #6469

Open asfimport opened 10 years ago

asfimport commented 10 years ago

I'm sometimes given a ShingleAnalyzerWrapper that I would like to change the shingle size on, so I need to create a new instance. However, I don't always know what the underlying analyzer is and I can't access it b/c it is a protected method on a final class.

The solution here is to make the getAnalyzer method public final for the ShingleAnalyzerWrapper.

Migrated from LUCENE-5406 by Grant Ingersoll (@gsingers), updated May 09 2016

asfimport commented 10 years ago

ASF subversion and git services (migrated from JIRA)

Commit 1559797 from @gsingers in branch 'dev/branches/branch_4x' https://svn.apache.org/r1559797

LUCENE-5406: backport from trunk

asfimport commented 10 years ago

ASF subversion and git services (migrated from JIRA)

Commit 1563855 from @bimargulies-google in branch 'dev/trunk' https://svn.apache.org/r1563855

6468: changes.txt; and fix a typo of Grant's for LUCENE-5406.

asfimport commented 10 years ago

ASF subversion and git services (migrated from JIRA)

Commit 1563868 from @bimargulies-google in branch 'dev/trunk' https://svn.apache.org/r1563868

6468, LUCENE-5406: move changes entries to 4.7.

asfimport commented 10 years ago

Shalin Shekhar Mangar (@shalinmangar) (migrated from JIRA)

I guess this has already been fixed and released in 4.7.

asfimport commented 10 years ago

Uwe Schindler (@uschindler) (migrated from JIRA)

Move issue to Lucene 4.9.