apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.59k stars 1.01k forks source link

Add @Monster annotation and run these tests periodically [LUCENE-5606] #6668

Open asfimport opened 10 years ago

asfimport commented 10 years ago

We have some awesome very heavy tests, Test2B*, but they are @Ignored and we never run them. I think we should add a new @Monster annotation and set up a Jenkins job with huge test timeout, big Java heap, etc.?


Migrated from LUCENE-5606 by Michael McCandless (@mikemccand), updated Apr 16 2014 Attachments: LUCENE-5606.patch

asfimport commented 10 years ago

Robert Muir (@rmuir) (migrated from JIRA)

+1 lets do this. These tests are currently Ignored and i dont remember the last time they were run. They might find bugs!

asfimport commented 10 years ago

Michael McCandless (@mikemccand) (migrated from JIRA)

There is a bug in Test2BTerms! I'll fix.

asfimport commented 10 years ago

Robert Muir (@rmuir) (migrated from JIRA)

Does Test2BFST really need 420G of heap? if so maybe it should stay ignored... thats .... \@Leviathan

asfimport commented 10 years ago

Robert Muir (@rmuir) (migrated from JIRA)

Here's a start to the patch.

You can run monster test group with -Dtests.monster=true, or stuff like -Dtest.monster=true -Dtestcase=Test2BTerms etc

Perhaps \@Monster should require the reason rather than having a default value? Its probably important for someone to realize what the special requirements are, but I don't really care.

asfimport commented 10 years ago

Michael McCandless (@mikemccand) (migrated from JIRA)

Does Test2BFST really need 420G of heap? if so maybe it should stay ignored... thats .... @Leviathan

As much as I would love to have an @Leviathan tag ...... I'm pretty sure that one is a typo :) I think 42G works, maybe less. Lemme try a binary search....

asfimport commented 10 years ago

Michael McCandless (@mikemccand) (migrated from JIRA)

Perhaps @Monster should require the reason rather than having a default value?

+1, so we can say "needs XXX heap" or "takes XXX hours".

asfimport commented 10 years ago

Mark Miller (@markrmiller) (migrated from JIRA)

+1, I love the forced documentation on annotations. bugUrl= on @BadApple has changed my life.

asfimport commented 10 years ago

ASF subversion and git services (migrated from JIRA)

Commit 1587769 from rmuir@apache.org in branch 'dev/trunk' https://svn.apache.org/r1587769

LUCENE-5606: un-ignore monster tests, instead annotate with a test group so they can be optionally run

asfimport commented 10 years ago

ASF subversion and git services (migrated from JIRA)

Commit 1587771 from rmuir@apache.org in branch 'dev/branches/branch_4x' https://svn.apache.org/r1587771

LUCENE-5606: un-ignore monster tests, instead annotate with a test group so they can be optionally run

asfimport commented 10 years ago

Michael McCandless (@mikemccand) (migrated from JIRA)

OK, Test2BFST hits OOME with only 30 GB heap but runs successfully on trunk (took \~4.5 hours) with 35 GB heap. I'll fix its javadocs claiming we need 420 GB heap :)

I'll set a up a cron job on my home beast box (48 GB RAM) to run this test periodically.

asfimport commented 10 years ago

ASF subversion and git services (migrated from JIRA)

Commit 1587871 from mikemccand@apache.org in branch 'dev/trunk' https://svn.apache.org/r1587871

LUCENE-5606: fix required heap for this test in the @Ignore reason

asfimport commented 10 years ago

ASF subversion and git services (migrated from JIRA)

Commit 1587872 from mikemccand@apache.org in branch 'dev/branches/branch_4x' https://svn.apache.org/r1587872

LUCENE-5606: fix required heap for this test in the @Ignore reason

asfimport commented 10 years ago

ASF subversion and git services (migrated from JIRA)

Commit 1588027 from mikemccand@apache.org in branch 'dev/trunk' https://svn.apache.org/r1588027

LUCENE-5606: fix test bug

asfimport commented 10 years ago

ASF subversion and git services (migrated from JIRA)

Commit 1588028 from mikemccand@apache.org in branch 'dev/branches/branch_4x' https://svn.apache.org/r1588028

LUCENE-5606: fix test bug

asfimport commented 10 years ago

ASF subversion and git services (migrated from JIRA)

Commit 1588031 from mikemccand@apache.org in branch 'dev/branches/lucene_solr_4_8' https://svn.apache.org/r1588031

LUCENE-5606: fix test bug