apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.63k stars 1.02k forks source link

Remove PointInRectQuery [LUCENE-7046] #8102

Closed asfimport closed 8 years ago

asfimport commented 8 years ago

This query is the same as a 2D PointRangeQuery, only slower, since it needs to do a bunch of decoding.

Instead we should just form PointRangeQuery's for bounding boxes for LatLonPoints: that just works on byte ranges.


Migrated from LUCENE-7046 by Robert Muir (@rmuir), resolved Feb 24 2016 Attachments: LUCENE-7046.patch (versions: 2)

asfimport commented 8 years ago

Robert Muir (@rmuir) (migrated from JIRA)

Here's a patch. I tried to do some cleanups (more iteration here is needed!!!) to LatLonPoint in general as well.

asfimport commented 8 years ago

Robert Muir (@rmuir) (migrated from JIRA)

A couple more cleanups:

asfimport commented 8 years ago

Michael McCandless (@mikemccand) (migrated from JIRA)

+1, looks awesome!

asfimport commented 8 years ago

ASF subversion and git services (migrated from JIRA)

Commit 77e62276f99d3d525aa2ee8681de4ff0f78e6c2a in lucene-solr's branch refs/heads/master from @rmuir https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=77e6227

LUCENE-7046: Remove PointInRectQuery, instead using 2-D PointRangeQuery for LatLonPoint