apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.48k stars 985 forks source link

Make BaseGeoPointTestCase more debuggable [LUCENE-7189] #8244

Open asfimport opened 8 years ago

asfimport commented 8 years ago

This class tests queries (boxes, circles, polygons) against indexed documents and fails if the query is wrong.

Unfortunately it can be hard to debug (depending which test method failed, if it was NIGHTLY, etc).

It is making issues challenging/slower to debug for me on #8240. In general i have found debugging geo related issues is difficult, we should invest more time to make this easier.

I think we want to display: 1) original item (e.g. Rectangle, radius, polygon) 2) query.toString() <-- can be different in important ways! 3) how many total documents were wrong 4) info on up to N (say 5) wrong documents: ID (not lucene docid) of doc. Lat/Lon location(s) of doc any relevant metric such as distance from origin 5) GeoTestUtil.toWebGLEarth output of html to visualize those N wrong documents, the query itself, any additional stuff like bounding box that might be useful plotted too.

I think the wrong documents we should try for one-line (rather than many) and we don't need to print stuff like deleted=false since these queries don't do anything sneaky here around that.


Migrated from LUCENE-7189 by Robert Muir (@rmuir), updated Apr 12 2016

asfimport commented 8 years ago

Michael McCandless (@mikemccand) (migrated from JIRA)

+1

I'll try to make the WebGL earth debugger easier to use ...

asfimport commented 8 years ago

Nick Knize (@nknize) (migrated from JIRA)

I can add my geojson string creator from luceneutil. Its great for simple geometry debugging on a 2D map. You just cut and paste the geojson string into http://geojson.io. For 3D we can continue to use the Earth GL string for a local globe viewer until a GeoJSON input pane is added to something like http://lucenegeo-iono.rhcloud.com/

asfimport commented 8 years ago

ASF subversion and git services (migrated from JIRA)

Commit 07d99765f56265997aaa74d5e0eaa4401b667151 in lucene-solr's branch refs/heads/master from Mike McCandless https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=07d9976

LUCENE-7189: make it easier to write WebGL earth HTML for debugging geo failures

asfimport commented 8 years ago

ASF subversion and git services (migrated from JIRA)

Commit 347b9f0d7f81ab881ac28b34b5f4477a82811321 in lucene-solr's branch refs/heads/branch_6x from Mike McCandless https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=347b9f0

LUCENE-7189: make it easier to write WebGL earth HTML for debugging geo failures

asfimport commented 8 years ago

Michael McCandless (@mikemccand) (migrated from JIRA)

I can add my geojson string creator from luceneutil.

+1, I think we need all the geo debugging help we can get!

asfimport commented 8 years ago

ASF subversion and git services (migrated from JIRA)

Commit 739c752cd30b73713a1334d67da4e3b4fc83f9c9 in lucene-solr's branch refs/heads/master from Mike McCandless https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=739c752

LUCENE-7189: use fewer sampling points for small earth-surface rectangles

asfimport commented 8 years ago

ASF subversion and git services (migrated from JIRA)

Commit 9cbe3e761b6e79acf62b8c6117704ce1656809b2 in lucene-solr's branch refs/heads/branch_6x from Mike McCandless https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9cbe3e7

LUCENE-7189: use fewer sampling points for small earth-surface rectangles

asfimport commented 8 years ago

ASF subversion and git services (migrated from JIRA)

Commit e034b04b065ca635553672d2b35c6b36578fd673 in lucene-solr's branch refs/heads/master from Mike McCandless https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e034b04

LUCENE-7189: improve geo debugging technology

asfimport commented 8 years ago

ASF subversion and git services (migrated from JIRA)

Commit 39d74d86cddfed5ec7f0dd9b4dcf0e102384d980 in lucene-solr's branch refs/heads/branch_6x from Mike McCandless https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=39d74d8

LUCENE-7189: improve geo debugging technology