search

apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.59k stars 1.01k forks source link

Move TermRangeQuery to sandbox [LUCENE-7336] #8390

Open asfimport opened 8 years ago

asfimport commented 8 years ago

I think, long ago, this class was abused for numeric range searching, if you converted your numeric terms into text terms "carefully", but we now have dimensional points for that, and I think otherwise this query class is quite dangerous: you can easily accidentally make a very costly query.

Furthermore, the common use cases for multi-term queries are already covered by other classes (PrefixQuery, WildcardQuery, FuzzyQuery).

Migrated from LUCENE-7336 by Michael McCandless (@mikemccand), updated Jun 08 2017

asfimport commented 8 years ago

Adrien Grand (@jpountz) (migrated from JIRA)

+1

asfimport commented 8 years ago

David Smiley (@dsmiley) (migrated from JIRA)

Is Sandbox the right place or Misc? What comes to mind when I think of sandbox is stuff that is in development or buggy. But maybe that's me; I have no convictions on the matter.

asfimport commented 8 years ago

Michael McCandless (@mikemccand) (migrated from JIRA)

I think sandbox should also be used for cases where we know there are problems with a class but in some rare use cases, where users understand those problems, it's perhaps useful, e.g. SlowFuzzyQuery.

I would put TermRangeQuery in this same category, but I guess not as extreme, so misc module is maybe also a good home.

asfimport commented 8 years ago

Michael McCandless (@mikemccand) (migrated from JIRA)

Bulk move of still open issues from 6.2 to 6.3.