search

apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.63k stars 1.02k forks source link

Size Estimator wrongly calculate Disk space in MB [LUCENE-8329] #9376

Open asfimport opened 6 years ago

asfimport commented 6 years ago

The size estimator dev tool ( dev-tools/size-estimator-lucene-solr.xls )currently :

Scope of this issue is just to fix these small mistakes. Out of scope is any improvement to the tool ( potentially separate Jira issues will follow)

Migrated from LUCENE-8329 by Alessandro Benedetti (@alessandrobenedetti), updated Jan 24 2020 Attachments: LUCENE-8329.patch Pull requests: https://github.com/apache/lucene-solr/pull/381

asfimport commented 6 years ago

Adrien Grand (@jpountz) (migrated from JIRA)

Which tool are you talking about? Is it https://github.com/mikemccand/luceneutil/blob/master/src/main/perf/DiskUsage.70.java?

asfimport commented 6 years ago

Alessandro Benedetti (@alessandrobenedetti) (migrated from JIRA)

Hi Adrien,  I am talking about the one included in the dev-tools in the Apache Lucene/Solr project :

dev-tools/size-estimator-lucene-solr.xls

I understand it is an old tool, but someone is still using it, so I just thought to contribute back these simple bug fixes.

For sure, that xls could be rewritten, but It's out of scope for this simple Jira :)

P.S. I attached the patch, but unfortunately it is unreadable. Being a binary file, it just replace it. This is annoying as I have done a minimal fix to the XSL but being on a Mac I had to export it via Numbers. So I end up not being sure if I broke any OS compatibility issue.

asfimport commented 6 years ago

Alessandro Benedetti (@alessandrobenedetti) (migrated from JIRA)

Patch is available but it involves a binary file change. So no easy to review and not easy to check with different OS

asfimport commented 6 years ago

Lucene/Solr QA (migrated from JIRA)

✔ +1 overall
Vote Subsystem Runtime Comment
Prechecks
master Compile Tests
Patch Compile Tests
Other Tests
0m 15s
Subsystem Report/Notes
JIRA Issue LUCENE-8329
JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12924731/LUCENE-8329.patch
Optional Tests
uname Linux lucene2-us-west.apache.org 4.4.0-112-generic #135-Ubuntu SMP Fri Jan 19 11:48:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool ant
Personality /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
git revision master / 71ed5ba
ant version: Apache Ant(TM) version 1.9.6 compiled on July 8 2015
modules C: U:
Console output https://builds.apache.org/job/PreCommit-LUCENE-Build/15/console
Powered by Apache Yetus 0.7.0 http://yetus.apache.org

This message was automatically generated.

asfimport commented 5 years ago

Lucene/Solr QA (migrated from JIRA)

✔ +1 overall
Vote Subsystem Runtime Comment
Prechecks
master Compile Tests
Patch Compile Tests
Other Tests
0m 11s
Subsystem Report/Notes
JIRA Issue LUCENE-8329
JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12924731/LUCENE-8329.patch
Optional Tests
uname Linux lucene1-us-west 4.4.0-137-generic #163\~14.04.1-Ubuntu SMP Mon Sep 24 17:14:57 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool ant
Personality /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
git revision master / 7830cae
ant version: Apache Ant(TM) version 1.9.3 compiled on July 24 2018
modules C: U:
Console output https://builds.apache.org/job/PreCommit-LUCENE-Build/179/console
Powered by Apache Yetus 0.7.0 http://yetus.apache.org

This message was automatically generated.

asfimport commented 4 years ago

Alessandro Benedetti (@alessandrobenedetti) (migrated from JIRA)

Any interest in fixing this? If there is not any intention in maintaining it, should we just remove it entirely? It could be misleading for people using it...

asfimport commented 4 years ago

Lucene/Solr QA (migrated from JIRA)

✔ +1 overall
Vote Subsystem Runtime Comment
Prechecks
master Compile Tests
Patch Compile Tests
Other Tests
0m 9s
Subsystem Report/Notes
JIRA Issue LUCENE-8329
JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12924731/LUCENE-8329.patch
Optional Tests
uname Linux lucene2-us-west.apache.org 4.4.0-170-generic #199-Ubuntu SMP Thu Nov 14 01:45:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool ant
Personality /home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
git revision master / 16e537d
ant version: Apache Ant(TM) version 1.9.6 compiled on July 20 2018
modules C: U:
Console output https://builds.apache.org/job/PreCommit-LUCENE-Build/249/console
Powered by Apache Yetus 0.7.0 http://yetus.apache.org

This message was automatically generated.

asfimport commented 4 years ago

David Smiley (@dsmiley) (migrated from JIRA)

I think simply remove it entirely as it's obsolete and not something I think we want to bother updating. I'll wait a bit if someone else has anything to add and remove it.