search

apache / lucene

Apache Lucene open-source search software
https://lucene.apache.org/
Apache License 2.0
2.69k stars 1.04k forks source link

Bump minimum Java version requirement to 11 [LUCENE-8738] #9783

Closed asfimport closed 5 years ago

asfimport commented 5 years ago

See vote thread for reference: https://markmail.org/message/q6ubdycqscpl43aq.

Migrated from LUCENE-8738 by Adrien Grand (@jpountz), resolved Apr 16 2019 Attachments: LUCENE-8738.patch, LUCENE-8738-javadoc-locale-en-US.patch, LUCENE-8738-solr-CoreCloseListener.patch Linked issues:

asfimport commented 5 years ago

Uwe Schindler (@uschindler) (migrated from JIRA)

Solr is not affected.

asfimport commented 5 years ago

Uwe Schindler (@uschindler) (migrated from JIRA)

Here is the final patch for the Java 11 change: LUCENE-8738.patch

asfimport commented 5 years ago

Uwe Schindler (@uschindler) (migrated from JIRA)

As noted on mailinglist, I will squash-merge this branch to master tomorrow, 2019-04-16 at 12:00 UTC. I will not delete this branch and keep it for reference (so commits can be reviewed).

asfimport commented 5 years ago

ASF subversion and git services (migrated from JIRA)

Commit ddd0bdcd876495ab2c3cc9bbf7b6648728af5be1 in lucene-solr's branch refs/heads/jira/LUCENE-8738 from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ddd0bdc

LUCENE-8738: Some missing documentation updates

asfimport commented 5 years ago

ASF subversion and git services (migrated from JIRA)

Commit faaee86efb01fa6e431fcb129cfb956c7d62d514 in lucene-solr's branch refs/heads/master from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=faaee86

LUCENE-8738: Move to Java 11 as minimum Java version (merged branch: jira/LUCENE-8738)

Co-authored-by: Adrien Grand <jpountz@apache.org>

asfimport commented 5 years ago

Uwe Schindler (@uschindler) (migrated from JIRA)

Hi, the change to Java 11 was committed to master branch. Please update your dev environments and do checks on master and 8.x branch before committing!

Thanks @jpountz for starting the issue.

@ErickErickson: Go ahead with fixing SOLR-13400 :-)

asfimport commented 5 years ago

ASF subversion and git services (migrated from JIRA)

Commit fb28958bc8cdec0ac20968222b03de7aed384032 in lucene-solr's branch refs/heads/master from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=fb28958

LUCENE-8738: Add Java 11 under "Getting Started" in CHANGES.txt

asfimport commented 5 years ago

ASF subversion and git services (migrated from JIRA)

Commit b8494c8702c84c0085f1382d7fa25c1848daf115 in lucene-solr's branch refs/heads/master from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=b8494c8

LUCENE-8738: Update Groovy to make the warnings with Java 11 a bit more silent (only one warning on first Groovy invocation)

asfimport commented 5 years ago

ASF subversion and git services (migrated from JIRA)

Commit f491369b4b27af7688c506ada4e7330a0c918a5a in lucene-solr's branch refs/heads/branch_8x from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=f491369

Backport of Java 11 change (LUCENE-8738): Update Groovy to make the warnings with Java 11 a bit more silent (only one warning on first Groovy invocation)

asfimport commented 5 years ago

ASF subversion and git services (migrated from JIRA)

Commit 77e1bec7dcc4641457dc161ddf5c55d73c85fb78 in lucene-solr's branch refs/heads/master from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=77e1bec

LUCENE-8738: Add missing dependency for Maven build

asfimport commented 5 years ago

ASF subversion and git services (migrated from JIRA)

Commit 3881b6df623bdce551d5c8befd366982c855c964 in lucene-solr's branch refs/heads/branch_8x from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=3881b6d

Backport of Java 11 change (LUCENE-8738): Add missing dependency for Maven build

asfimport commented 5 years ago

ASF subversion and git services (migrated from JIRA)

Commit 5aaa923e360bc5c670230445bb710d07ba4a4655 in lucene-solr's branch refs/heads/master from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=5aaa923

LUCENE-8738, SOLR-13400: Remove obsolete changes entry (replaced by SOLR-13400)

asfimport commented 5 years ago

Tomoko Uchida (@mocobeta) (migrated from JIRA)

Locale-spacific failure report: After checking out master branch, ant precommit fails on my PC (fedora linux) with this error.

-documentation-lint:
     [echo] checking for broken html...
    [jtidy] FIXME: Broken HTML checks were disabled, as jtidy can't handle HTML5.
     [echo] Checking for broken links...
     [exec] 
     [exec] Crawl/parse...
     [exec] 
     [exec] Verify...
     [echo] Checking for missing docs...
     [exec] Traceback (most recent call last):
     [exec]   File "/home/moco/repo/lucene-solr/dev-tools/scripts/checkJavaDocs.py", line 387, in <module>
     [exec]     if checkPackageSummaries(sys.argv[1], level):
     [exec]   File "/home/moco/repo/lucene-solr/dev-tools/scripts/checkJavaDocs.py", line 361, in checkPackageSummaries
     [exec]     if (level == 'class' or level == 'method') and checkSummary('%s/package-summary.html' % dirPath):
     [exec]   File "/home/moco/repo/lucene-solr/dev-tools/scripts/checkJavaDocs.py", line 311, in checkSummary
     [exec]     raise RuntimeError('BUG: failed to locate description in %s' % fullPath)
     [exec] RuntimeError: BUG: failed to locate description in build/docs/analyzers-kuromoji/org/apache/lucene/analysis/ja/package-summary.html

BUILD FAILED

As far as I found, seems JDK11's javadoc tool ignores the "-locale en_US" parameter (on both of fedora linux and windows) and Javadocs is generated with default locale (in my case, "ja_JP") by ant documentation target, so the python linter failed.

I use JDK 11.0.2.

java -version
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.2+9)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.2+9, mixed mode)

And this (dirty) patch works for me anyway...

--- a/lucene/common-build.xml
+++ b/lucene/common-build.xml
`@@` -184,7 +184,7 `@@`
   <property name="javadoc.noindex" value="true"/>

   <!---TODO: Fix accessibility (order of H1/H2/H3 headings), see #9775 -->
-  <property name="javadoc.doclint.args" value="-Xdoclint:all -Xdoclint:-missing -Xdoclint:-accessibility"/>
+  <property name="javadoc.doclint.args" value="-Xdoclint:all -Xdoclint:-missing -Xdoclint:-accessibility -J-Duser.language=en -J-Duser.country=US"/>
   <!---proc:none was added because of [LOG4J2-1925](https://issues.apache.org/jira/browse/LOG4J2-1925) / JDK-8186647 -->
   <property name="javac.doclint.args" value="-Xdoclint:all/protected -Xdoclint:-missing -Xdoclint:-accessibility -proc:none"/>
asfimport commented 5 years ago

Uwe Schindler (@uschindler) (migrated from JIRA)

The hack Paramus are fine, but don't put them into doclint params, as those are different for Solr.

The correct place is to put it into the "arg line" in the javadocs macro.

asfimport commented 5 years ago

Tomoko Uchida (@mocobeta) (migrated from JIRA)

I attached a patch: LUCENE-8738-javadoc-locale-en-US.patch , this adds "<arg line=.../>" to the javadocs macro.

Can I commit it to the master branch?

LUCENE-8738-javadoc-locale-en-US.patch ```diff diff --git a/lucene/common-build.xml b/lucene/common-build.xml index d1d0d7f1c5..1f542fa5f7 100644 --- a/lucene/common-build.xml +++ b/lucene/common-build.xml @@ -2131,6 +2131,8 @@ ${ant.project.name}.test.dependencies=${test.classpath.list} + + ```
asfimport commented 5 years ago

Uwe Schindler (@uschindler) (migrated from JIRA)

I opened https://bugs.openjdk.java.net/browse/JDK-8222791 about the split packages problem.

@Tomoko Uchida: Can you give a detailed description how the Javadocs are broken with Japanese Locale? I'll open a bug report in JDK. Just send me an email with the text and reproduce line (ideally without lucene) and whats exactly wrong in the mail. I'll copypaste into the issue.

asfimport commented 5 years ago

Uwe Schindler (@uschindler) (migrated from JIRA)

Can I commit it to the master branch?

Go ahead!

asfimport commented 5 years ago

ASF subversion and git services (migrated from JIRA)

Commit 1204327b56b114d980ad2ca4706c43e01faff6d9 in lucene-solr's branch refs/heads/master from Tomoko Uchida https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1204327

LUCENE-8738: Force locale to be 'en_US' in javadocs task.

asfimport commented 5 years ago

ASF subversion and git services (migrated from JIRA)

Commit 2e3a81a8882ca6627c91254a991703910adadf6f in lucene-solr's branch refs/heads/branch_8x from Tomoko Uchida https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2e3a81a

LUCENE-8738: Force locale to be 'en_US' in javadocs task.

asfimport commented 5 years ago

Tomoko Uchida (@mocobeta) (migrated from JIRA)

I pushed the change to master and branch_8x.

asfimport commented 5 years ago

Uwe Schindler (@uschindler) (migrated from JIRA)

JDK issue: https://bugs.openjdk.java.net/browse/JDK-8222793

asfimport commented 5 years ago

ASF subversion and git services (migrated from JIRA)

Commit 87c16882ae3606efd1ff88fd369ca964685d3ae9 in lucene-solr's branch refs/heads/master from Uwe Schindler https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=87c1688

LUCENE-8738, #9830: Fix ECJ linter to accept Java 11 syntax

asfimport commented 2 years ago

Adrien Grand (@jpountz) (migrated from JIRA)

Closing after the 9.0.0 release