Test review A-D, #259 - Githubissues

apache / lucenenet

Apache Lucene.NET

https://lucenenet.apache.org/

Apache License 2.0

2.24k stars 639 forks source link

Test review A-D, #259 #1018

Closed paulirwin closed 4 days ago

paulirwin commented 1 week ago

[X] You've read the Contributor Guide and Code of Conduct.
[X] You've included unit or integration tests for your change, where applicable.
[X] You've included inline docs for your change, where applicable.
[X] There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Test review for core A-D tests

Fixes #259 (as the final PR for this issue)

Description

Add missing comments and attributes, match formatting, remove unnecessary code, etc.

paulirwin commented 4 days ago

Reverted breaking change and removed label, will put in a separate PR with that label. Thanks!