[X] You've included unit or integration tests for your change, where applicable.
[ ] You've included inline docs for your change, where applicable.
[X] There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.
Implement ISpanAppendable in CharBlockArray and CharTermAttributeImpl
Fixes #1026
Description
This adds ISpanAppendable to the CharBlockArray and CharTermAttributeImpl classes. The classes implement the interface explicitly so that we can provide a default implementation that returns itself rather than ISpanAppendable, to match the existing Append overloads.
Note that while IAppendable is now redundant in the interface list for these types, I left it there for Lucene source compatibility and reference, since ISpanAppendable does not exist in Lucene.
@NightOwl888 I intend to mark this ready for review once #1018 is merged, leaving as draft for now. I'll also likely have to resolve a merge conflict at that point too.
Implement
ISpanAppendable
inCharBlockArray
andCharTermAttributeImpl
Fixes #1026
Description
This adds
ISpanAppendable
to theCharBlockArray
andCharTermAttributeImpl
classes. The classes implement the interface explicitly so that we can provide a default implementation that returns itself rather thanISpanAppendable
, to match the existing Append overloads.Note that while
IAppendable
is now redundant in the interface list for these types, I left it there for Lucene source compatibility and reference, sinceISpanAppendable
does not exist in Lucene.