Closed NightOwl888 closed 6 days ago
Looks good, unless we wanted to share EncodingProviderInitializer between the projects in Lucene.Net core.
Yeah, I thought of that, but it requires a dependency on System.Text.Encoding.CodePages
. So, the best we can do to share this is to make it a linked file that does not a belong to any project.
There is quite a bit of duplicated code in these analysis projects (for example CSVUtil in kuromoji and nori), so this seems like the trend.
Summary of the changes (Less than 80 chars)
Fixed encoding provider loading on .NET Framework (for .NET Standard 2.0 target)
Fixes #1025
Description
Added
EncodingProviderInitializer
class toLucene.Net.Analysis.Kuromoji
andLucene.Net.Analysis.SmartCn
to prevent loading problems on thenetstandard2.0
target when the runtime is .NET Framework.