apache / mahout

Mirror of Apache Mahout
Apache License 2.0
2.14k stars 945 forks source link

MAHOUT-454 Notebook Testing #462

Closed rawkintrevo closed 1 month ago

rawkintrevo commented 1 month ago

Purpose of PR:

Please give a short description of what this PR is for.

Important ToDos

Please mark each with an "x"

If all of these things aren't complete, but you still feel it is appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"

Does this change break earlier versions?

Is this the beginning of a larger project for which a feature branch should be made?

Evidence of successful run: https://github.com/apache/mahout/actions/runs/10724164981

rawkintrevo commented 1 month ago

in it's current implementation- the test fails if any cell in any notebook fails- it is possible w/o much extra effort to layer in a testing framework (ie pytest) but i didn't realize we had that already in, or understand enough about it, i would make "add pytest to notebook tests' a follow on issue

rawkintrevo commented 1 month ago

or, discussion point- add tests in pytest for the notebooks