apache / maven-mvnd

Apache Maven Daemon
https://maven.apache.org/
Apache License 2.0
2.85k stars 205 forks source link

Remove outdated note about oh-my-zsh #1034

Closed albihasani94 closed 2 weeks ago

albihasani94 commented 2 weeks ago

As a first-time user of the Maven Daemon, I was reading the README to make sure I apply everything that is relevant in my context.

I was curious about the note to the oh-my-zsh users, about a previous incompatibility between mvnd and the alias of the mvn deploy used by the omz maven plugin.

On a second look, it seems that the incompatibility has been resolved because oh-my-zsh has renamed mvnd to mvndp to resolve this particular problem.

Please check the relevant commit: https://github.com/ohmyzsh/ohmyzsh/pull/11756 and the linked issue: https://github.com/ohmyzsh/ohmyzsh/issues/11713

The up-to-date omz maven plugin documentation reflects the change: https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/mvn

Alias Command
mvndp mvn deploy

Since this incompatibility seems to be no longer possible, I would suggest to drop this section from the documentation.

P.S. My PR does not link to an issue since I just considered it a simple cleanup. Should I create one?