search

apache / maven-mvnd

Apache Maven Daemon
https://maven.apache.org/
Apache License 2.0
2.85k stars 205 forks source link

Provide a choco package #160

Open OLibutzki opened 3 years ago

OLibutzki commented 3 years ago

For Windows users it would be very convenient to ship mvnd via choco.

jbang already has a choco package, so this might be a good inspiration.

ppalaga commented 3 years ago

Contributions are highly welcome!

famod commented 3 years ago

FTR, this is what I found in jbang: https://github.com/jbangdev/jbang/tree/master/src/main/scripts/choco

johanjanssen commented 3 years ago

I've created a first version: https://github.com/johanjanssen/ChocolateyPackages/tree/master/mvndaemon

Please let me know if you have any remarks.

I've already submitted the package to Chocolatey. But they have to moderate it, which can take several weeks. After a while, the package hopefully becomes trusted and then I can release them and they become available after some automated checks.

ppalaga commented 3 years ago

That's a great news, thanks @johanjanssen!

It is fully OK if you prefer to maintain the files under your GH account but I am also open to a similar model we have with Brew: Michael Simons donated the Brew repo to mvndaemon GH organization and we gave him committer permissions there. This made it possible to somewhat distribute the work on various Brew issues that appeared in course of time. Esp. it allowed us to tune the release process that is now fully CI driven. I admit I have no idea how Chocolatey works and whether automated releases are possible at all.

johanjanssen commented 3 years ago

Good one, we can see how we do manage that over time. I don't mind too much, for me this was the quickest solution :). Just to make sure the package gets in the moderation queue at Chocolatey.

We can definitely automate it more, and I might even be able to use Michael's scripts for that. Thanks for the tip!

johanjanssen commented 3 years ago

The Chocolatey package is approved and generally available: https://chocolatey.org/packages/mvndaemon

jglick commented 2 years ago

It does not install a required DLL: #607

johanjanssen commented 2 years ago

It indeed only installs the mvndaemon itself and adds it to the path. When I created and tested the package it worked and it has quite some downloads without any remarks.

Unfortunately at this point in time I don't have a Windows machine available to test the current behavior and if needed change the package. If the mvndaemon team say that the DLL should always be installed and someone can change and test the Chocolatey scripts, then I can release a new version based on that.

OLibutzki commented 3 weeks ago

With mvnd 1.0.0 being released, this issue deserves some attention.

Maybe it's worth looking a JReleaser which supports building SDKMan, Homebrew and Chocolatey packages. From an external point of view, mvnd seems to be a good candidate for JReleaser. /cc @aalmiray

// Edit From the README file:

We’re looking for contribution to support MacPorts, Chocolatey, Scoop or asdf. If you fancy helping us…​

JReleaser supports all of them...

OLibutzki commented 3 weeks ago

Just realized that I pointed to JReleaser some time ago: https://github.com/apache/maven-mvnd/issues/884#issuecomment-1784710330

623 by @gnodet is related, too.

aalmiray commented 3 weeks ago

FWIW I believe mvnd accepted a PR more than a year ago that configured JReleaser for its releases. However, additional auth and vetting from ASF was required for using GH 3rd party actions such as oracle/setup-graal and jreleaser/release-action IIRC.

Perhaps that is no longer an obstacle. Happy to help get this done.

johanjanssen commented 3 weeks ago

My 2 cents: I no longer maintain the Chocolatey package. It's now maintained by @ajshastri ajshastri.

OLibutzki commented 3 weeks ago

@johanjanssen so this is the active repository? https://github.com/ajshastri/chocolatey-packages Unfortunately it's not possible to add issues. Not sure how to get in contact.

johanjanssen commented 3 weeks ago

I assume so, normally I just ping him like I did above. Otherwise you can contact Chocolatey maintainers via their package website: https://community.chocolatey.org/packages/mvndaemon

ajshastri commented 3 weeks ago

@OLibutzki I've updated the package. I've also updated the repo to have issues.

cstamas commented 3 weeks ago

Sadly, mvnd 1.0.0 seems busted on Windows, at least the console output, see #1033 and related issue :disappointed:

gnodet commented 3 weeks ago

FWIW I believe mvnd accepted a PR more than a year ago that configured JReleaser for its releases. However, additional auth and vetting from ASF was required for using GH 3rd party actions such as oracle/setup-graal and jreleaser/release-action IIRC.

Perhaps that is no longer an obstacle. Happy to help get this done.

This hasn't changed. We still need vote. So we need the release manager to perform some tasks. But if the packaging for third party installers can be done in a subsequent script, such as in https://github.com/apache/maven-mvnd/blob/master/build/release-publish.sh#L32-L33 (those 2 scripts could be rewritten to leverage JReleaser if it makes sense), that would be nice.