Use ThreadLocal for FtpResponseEncoder.ENCODER.

apache / mina-ftpserver

Apache Mina FTP Server

Apache License 2.0

50 stars 27 forks source link

Use ThreadLocal for FtpResponseEncoder.ENCODER. #11

Closed zhanghai closed 2 years ago

zhanghai commented 2 years ago

CharsetEncoder isn't thread safe so the original code often crashes when there are multiple responses being encoded concurrently. We can use a ThreadLocal for the CharsetEncoder to fix this.

elecharny commented 2 years ago

Patch applied in 1.1.X and 1.2.X branches. Many thanks !

elecharny commented 2 years ago

Note that we now have 2 branches for the project:

1.1.X for any 1.1. version patches
1.2.X for any 1.2 version patches

Can you close the PR?

Thanks !

elecharny commented 2 years ago

Well, I can close it myself :-)