search

apache / mina-ftpserver

Apache Mina FTP Server
Apache License 2.0
50 stars 27 forks source link

Shall we remove or upgrade the log4j 1.2.17.jar #3

Open lingyanmeng opened 2 years ago

lingyanmeng commented 2 years ago

I built the 1.1.2, the good news is that the log4j api is 2.17, however, the log4j 1.2.17.jar is still there, is that required? I would suggest upgrading it: image

I also tested by remove it directly, it doesn't work.

elecharny commented 2 years ago

An upgrade would be very welcome.

There is still some parts where we use log4j1.2 ('typically the MDC feature).

If you have a PR, I can apply it !

lingyanmeng commented 2 years ago

Ok, will do it in this week. My plan is to replace log4j-1.2.17 and slf4j-log4j12-1.7.32 with log4j-slf4j-impl-2.17.1 and keep slf4j-api-1.7.32 and jcl-over-slf4j-1.7.32; and upgrade the log4j to 2.17.1. Let me know if you have any concerns.

elecharny commented 2 years ago

No concern :-)

lingyanmeng commented 2 years ago

I tried but failed, there are more dependencies than I thought, still working on it.

elecharny commented 2 years ago

We are going to use log4j 2.17.1 in FtpServer 1.1.3 (committed yesterday)