search

apache / mina-sshd

Apache MINA sshd is a comprehensive Java library for client- and server-side SSH.
https://mina.apache.org/sshd-project/
Apache License 2.0
885 stars 358 forks source link

[SSHD-1237] Handle keep-alive channel requests #492

Closed tomaswolf closed 5 months ago

tomaswolf commented 5 months ago

OpenSSH server sends keep-alive requests as channel requests if a channel is open. Handle these channel requests in the "last-resort" channel request handler.

gnodet commented 5 months ago

OpenSSH server sends keep-alive requests as channel requests if a channel is open. Do not log a warning about such requests, simply send back a failure reply. OpenSSH just expects any reply, whether success or failure.

Not displaying the warning looks weird. Wouldn’t it be cleaner to « support » them instead and reply with a success or failure ?

tomaswolf commented 5 months ago

Not displaying the warning looks weird. Wouldn’t it be cleaner to « support » them instead and reply with a success or failure ?

Done.