search

apache / mina-sshd

Apache MINA sshd is a comprehensive Java library for client- and server-side SSH.
https://mina.apache.org/sshd-project/
Apache License 2.0
847 stars 353 forks source link

Fix mina full class name in BuiltinIoServiceFactoryFactories #511

Closed JinHeap closed 1 month ago

JinHeap commented 1 month ago

Addresses https://github.com/apache/mina-sshd/issues/510

tomaswolf commented 1 month ago

Thanks. The change is good, but now that this is fixed DefaultIoServiceFactoryFactoryTest hangs for MINA during disposal of the partially set up (with mocks) MinaServiceFactory. Previously it just skipped the non-existing class.

Also, BuiltinIoServiceFactoryFactoriesTest should have a test that fails if one of the enum constants has a wrong class name. I.e., a test that would have uncovered the original problem (wrong string).

I'll see if I can amend this commit to fix these test issues.

JinHeap commented 1 month ago

thanks. then if need me do something, please tell me.

tomaswolf commented 1 month ago

Merged as commit 82e0ed1f.