search

apache / mxnet

Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more
https://mxnet.apache.org
Apache License 2.0
20.77k stars 6.79k forks source link

Many operators don't have unit tests. #10923

Open zheng-da opened 6 years ago

zheng-da commented 6 years ago

Our Python unit tests don't cover all operators. Recently, I found softmax activation was never tested and the test has been added in https://github.com/apache/incubator-mxnet/pull/10918. Currently, the backward computation of norm doesn't have GPU tests. I'm afraid more operators don't have unit tests.

eric-haibin-lin commented 6 years ago

Also https://github.com/apache/incubator-mxnet/issues/10868

eric-haibin-lin commented 6 years ago

We need to make a list tracking missing unit tests

zheng-da commented 6 years ago

can we create a list and somehow still keep track of them? not sure doing something like below is a good way.

anirudhacharya commented 6 years ago
anirudhacharya commented 5 years ago

initializer.py has very less test coverage

anirudhacharya commented 5 years ago

Missing Gradient Checks - https://github.com/apache/incubator-mxnet/issues/13254

apeforest commented 5 years ago

@mxnet-label-bot add [Good First Issue]

anirudhacharya commented 5 years ago

Missing Optimizer tests -

hanzhaogang commented 5 years ago

@zheng-da What skills and knowledge are required to write the test code? How do we test operators? Checked the test_subgraph_op.py whihc I think should be a test for the subgraph operator in the incubator-mxnet/tests/python/unittest/ package but still have no idea how to contribute.

cchung100m commented 5 years ago

Missing Optimizer tests -

  • [ ] Large batch BSGD
  • [ ] Delay compensation asynchronous SGD
  • [x] SGLD
  • [x] AdaDelta
  • [x] Adamax
  • [ ] Nadam

Hi @anirudhacharya ,

It's been a while since the checked missing unit tests last year, and I checked Nadam has test, I would appreciate if you can point me where can I find the latest list of missing unit tests.

Many thanks,

anirudhacharya commented 5 years ago

@cchung100m I am afraid this is the only list of missing unit tests. I have updated the list based on my knowledge.

anirudh2290 commented 5 years ago