search

apache / mxnet

Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more
https://mxnet.apache.org
Apache License 2.0
20.77k stars 6.8k forks source link

Move Scala Bucketing Code to the Main Package #14111

Open gigasquid opened 5 years ago

gigasquid commented 5 years ago

The BucketIO.scala https://github.com/apache/incubator-mxnet/blob/master/scala-package/examples/src/main/scala/org/apache/mxnetexamples/rnn/BucketIo.scala in the current example Scala would be very useful in the main package to work with BucketingModule (see example https://github.com/apache/incubator-mxnet/blob/master/scala-package/examples/src/main/scala/org/apache/mxnetexamples/rnn/LstmBucketing.scala#L96 scala-)

This would enable the JVM languages to build NLP support more easily in the packages without having to reimplement bucketing.

For reference the python package does provide support for this https://github.com/apache/incubator-mxnet/blob/master/example/rnn/bucketing/lstm_bucketing.py#L79 https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/rnn/io.py#L84

mxnet-label-bot commented 5 years ago

Hey, this is the MXNet Label Bot. Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it. Here are my recommended labels: Scala, Feature, Doc