search

apache / mxnet

Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more
https://mxnet.apache.org
Apache License 2.0
20.78k stars 6.79k forks source link

FindMKL.cmake small bugs #19151

Closed sfraczek closed 4 years ago

sfraczek commented 4 years ago

Description

  1. cmake/Modules/FindMKL.cmake doesn't search $HOME/intel path, but only /opt/intel. I believe it could search both because if mkl is installed without sudo, it is installed in $HOME/intel.
  2. mklvars.sh exports env variable MKLROOT therefore FindMKL should search in ENV{MKLROOT} instead of ENV{MKL_ROOT} because MKL_ROOT is cmake variable.
  3. Unused cmake variables INTEL_ROOT INTEL_RTL_ROOT should be replaced with MKL_ROOT.

To Reproduce

Run cmake after running source ../path/to/mklvars.sh or set environment variable MKLROOT manually and see that it doesn't find MKL properly.

github-actions[bot] commented 4 years ago

Welcome to Apache MXNet (incubating)! We are on a mission to democratize AI, and we are glad that you are contributing to it by opening this issue. Please make sure to include all the relevant context, and one of the @apache/mxnet-committers will be here shortly. If you are interested in contributing to our project, let us know! Also, be sure to check out our guide on contributing to MXNet and our development guides wiki.

pengzhao-intel commented 4 years ago

@anko-intel