search

apache / mxnet

Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more
https://mxnet.apache.org
Apache License 2.0
20.77k stars 6.8k forks source link

question about function _get_optimal_threshold #19235

Closed wanghr323 closed 3 years ago

wanghr323 commented 3 years ago

Hello, I’m doing work on the weighting of the convolutional layer. I tried the "_get_optimal_threshold" function of incubator-mxnet/python/mxnet/contrib/quantization.py in mxnet, but I found that no matter what value I pass in , The final threshold return value of this function will return the maximum and minimum values of arrary (finally implemented using the C function), but when I try to use the v1.0.0 version, his return value is different (finally use python achieve). Why is the return value of the two versions of the function so different? Is there a problem with my usage?

github-actions[bot] commented 3 years ago

Welcome to Apache MXNet (incubating)! We are on a mission to democratize AI, and we are glad that you are contributing to it by opening this issue. Please make sure to include all the relevant context, and one of the @apache/mxnet-committers will be here shortly. If you are interested in contributing to our project, let us know! Also, be sure to check out our guide on contributing to MXNet and our development guides wiki.

sfraczek commented 3 years ago

Hi, What do you mean by v1.0.0 version? Could you give a link to code of that version?

wanghr323 commented 3 years ago

sorry，its the branch v1.2.0…… function is in https://github.com/apache/incubator-mxnet/blob/v1.2.0/python/mxnet/contrib/quantization.py line249

sfraczek commented 3 years ago

I think the old version is buggy. I got an error when executing it. How are you using the new one?

sfraczek commented 3 years ago

@szha Can we close this issue?