search

apache / mxnet

Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more
https://mxnet.apache.org
Apache License 2.0
20.79k stars 6.79k forks source link

MKLDNN header missing in mxnet head #20054

Closed EnricoMi closed 3 years ago

EnricoMi commented 3 years ago

Description

Horovod does not compile with mxnet-2.0.0b20210317 due to missing mkldnn header files. It did with earlier head snapshots.

Error Message

Compiling Horovod with it, I get the usual

  MXNet was found with mkl-dnn support but mkldnn header files are missing.
  Please, install MXNet with mkldnn header files.

To Reproduce

Horovod integration tests compile against mxnet head:

https://buildkite.com/organizations/horovod/pipelines/horovod/builds/5118/jobs/aa1d13eb-069c-4fb9-95a3-b96bf821ca16/raw_log

Is there a fundamental reason why mkldnn headers are dropped from releases and head snapshots from time to time? Can / do CI pipeline check for their existence?

github-actions[bot] commented 3 years ago

Welcome to Apache MXNet (incubating)! We are on a mission to democratize AI, and we are glad that you are contributing to it by opening this issue. Please make sure to include all the relevant context, and one of the @apache/mxnet-committers will be here shortly. If you are interested in contributing to our project, let us know! Also, be sure to check out our guide on contributing to MXNet and our development guides wiki.

leezu commented 3 years ago

mkldnn was renamed to onednn by Intel and MXNet nomenclature was updated in https://github.com/apache/incubator-mxnet/commit/aa92db02201799841bf52db5a0b8507719f04e61 including renaming include/mkldnn folder name to include/onednn

EnricoMi commented 3 years ago

So you are saying Horovod should update the way it detects mkldnn/onednn headers, as well as including it?

leezu commented 3 years ago

Updating the include dirs in horovod's cmake detection code should be sufficient.

EnricoMi commented 3 years ago

Fixing this then in Horovod. Thanks for the quick support.