Barrier for Horovod KV Store API

apache / mxnet

Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more

https://mxnet.apache.org

Apache License 2.0

20.73k stars 6.81k forks source link

Barrier for Horovod KV Store API #21217

Open rbyche opened 9 months ago

rbyche commented 9 months ago

Description

Added barrier function, which was missing from Horovod KV Store API.

Checklist

Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Changes

[x] Add _barrier function to kvstore.Horovod

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

mxnet-bot commented 9 months ago

Hey @rbyche , Thanks for submitting the PR All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

To trigger all jobs: @mxnet-bot run ci [all]
To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, miscellaneous, unix-gpu, website, sanity, centos-gpu, windows-cpu, windows-gpu, unix-cpu, clang, edge]

Note: Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. All CI tests must pass before the PR can be merged.

rbyche commented 9 months ago

@mxnet-bot run ci [centos-gpu, edge, miscellaneous, unix-gpu, website]

mxnet-bot commented 9 months ago

Jenkins CI successfully triggered : [miscellaneous, website, unix-gpu, centos-gpu, edge]