search

apache / mynewt-mcumgr

Apache mynewt
https://mynewt.apache.org/
99 stars 76 forks source link

fs mgmt not working under zephyr 2.5 #116

Closed niclas-ats closed 3 years ago

niclas-ats commented 3 years ago

It seems like the fs_mgmt_impl_read and fs_mgmt_impl_write functions are missing a proper initialization of the local struct fs_file_t file variable. The attached patch fixes the up-/download of files for me.

0001-zephyr-fix-initialization-of-file-struct.txt

de-nordic commented 3 years ago

Can you post PR with the fix?

niclas-ats commented 3 years ago

Will this be picked up by https://github.com/zephyrproject-rtos/mcumgr as well? Or do I need to create a seperate pull request in that repo?

de-nordic commented 3 years ago

Yes, I will do the snapshot update.

niclas-ats commented 3 years ago

The fix didn't make it into yesterdays snapshot update. Once it's there I can test it and then close this issue.

de-nordic commented 3 years ago

The fix didn't make it into yesterdays snapshot update. Once it's there I can test it and then close this issue.

Yes, it was little late to the party and the snapshot update has been already waiting for some time due to Zephyr release.

niclas-ats commented 3 years ago

Nevermind. I'll use my fork in the meantime. Thx for the quick approval!

de-nordic commented 3 years ago

@niclas-ats Can you close the issue?

de-nordic commented 3 years ago

Thanks!