search

apache / mynewt-mcumgr

Apache mynewt
https://mynewt.apache.org/
99 stars 76 forks source link

samples/smp_svr: Update of Zephyr sample #62

Closed de-nordic closed 4 years ago

de-nordic commented 4 years ago

Discussion continues here: https://github.com/apache/mynewt-mcumgr/pull/60

The Zephyr version of mcumgr/smp_svr sample has been updated with current (commit d380622a) version of source code from Zephyr repository: zephyrpoject-rots/zephyr/tree/master/samples/subsys/mgmt/mcumgr/smp_svr

Signed-off-by: Dominik Ermel dominik.ermel@nordicsemi.no

utzig commented 4 years ago

@de-nordic Doing a tree diff between current smp_svr in Zephyr and this PR, I see two differences:

1) There is a prj.conf.tiny file here and not in Zephyr, should it be removed? 2) There is a sample.yaml file in Zephyr that is not added here, should it be added?

Apart from those changes, everything looks fine.

de-nordic commented 4 years ago

@de-nordic Doing a tree diff between current smp_svr in Zephyr and this PR, I see two differences:

1. There is a `prj.conf.tiny` file here and not in Zephyr, should it be removed?

2. There is a `sample.yaml` file in Zephyr that is not added here, should it be added?

Apart from those changes, everything looks fine.

1) yes it should, that is my mistake 2) it should be there; I have removed it because somehow I thought that there is no reason to include it to mynewt fork which is stupid, if we take into account that this should be exact sync of the sample from zephyr

Thanks for reviewing.