search

apache / mynewt-mcumgr

Apache mynewt
https://mynewt.apache.org/
99 stars 76 forks source link

ext: lib: mgmt: Enabling Zephyr/mynewt-core version of tinycbor #71

Closed de-nordic closed 4 years ago

de-nordic commented 4 years ago

Changes needed due to overwrite of Zephyr fork of Tinycbor with mynewt-core version.

Signed-off-by: Dominik Ermel dominik.ermel@nordicsemi.no

utzig commented 4 years ago

Is this dependent on the merge of https://github.com/zephyrproject-rtos/tinycbor/pull/11 ?

de-nordic commented 4 years ago

Is this dependent on the merge of zephyrproject-rtos/tinycbor#11 ?

It is dependent for Zephyr, as zephyr will not compile if both changes (this and tinycbor) are done at the same time.

carlescufi commented 4 years ago

@utzig @sjanc can we merge this?

utzig commented 4 years ago

@utzig @sjanc can we merge this?

I honestly did not understand @de-nordic comment, but I believe you both know what you're doing!

carlescufi commented 4 years ago

Thanks! @utzig we are trying to consolidate tinycbor so that it's the same as in mynewt.

utzig commented 4 years ago

I honestly did not understand @de-nordic comment, but I believe you both know what you're doing!

To be clear, this obviously only affects Zephyr, so there's no point in saying it. What was not clear to me is where the changes that add tinycbor from Mynewt on Zephyr are, but you both sure of the change, and I don't see anything wrong with it either!