search

apache / mynewt-newt

An OS to build, deploy and securely manage billions of devices
https://mynewt.apache.org/
Apache License 2.0
117 stars 96 forks source link

cmake: Make CMakeLists.txt more readable #401

Closed michal-narajowski closed 4 years ago

kasjer commented 4 years ago

CMakeLists.txt look much nicer now. :+1: But since you are changing style only maybe you could break lines to reasonable length (optionally). Having lines with thousands of character is difficult to check.

But this is just a suggestion. It is improvement by itself. Great work as usual.

michal-narajowski commented 4 years ago

@kasjer I agree, I want to do that too, but it will require a bit more work as most of those long lines are generated from lists of flags or files. I will add another PR later that changes that.