search

apache / mynewt-newtmgr

Newt Manager (newtmgr) is the application tool that enables a user to communicate with and manage remote devices running the Mynewt OS
https://mynewt.apache.org/
Apache License 2.0
35 stars 77 forks source link

ProcessMissedChunks() does not process chunck with IMAGE_UPLOAD_CHUNK_MISSED_WM status #186

Open ubicore opened 3 years ago

ubicore commented 3 years ago

If c is == to IMAGE_UPLOAD_CHUNK_MISSED_WM, chunck is never retransmitted ? https://github.com/apache/mynewt-newtmgr/blob/master/nmxact/xact/image.go#L249 Maybe the test : if c < IMAGE_UPLOAD_CHUNK_MISSED_WM { should be : if c <= IMAGE_UPLOAD_CHUNK_MISSED_WM { or if c < 0 {

?