search

apache / mynewt-nimble

Apache mynewt
https://mynewt.apache.org/
Apache License 2.0
691 stars 394 forks source link

reserved identifier violation #1604

Open elfring opened 1 year ago

elfring commented 1 year ago

I would like to point out that identifiers like “‎_MESH_GLUE_‎” and “‎__MODEL_CLI_H__‎” do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

sjanc commented 1 year ago

Hi,

I don't mind changing this to be C++ compliant. Please have a look at https://github.com/apache/mynewt-nimble/pull/1613