apache / nano

Nano is now part of Apache CouchDB. Repo moved to https://GitHub.com/apache/couchdb-nano
https://github.com/apache/couchdb-nano
Other
1.13k stars 157 forks source link

insertDocument API broken backwards compatibility (cannot update document) #288

Open nacho4d opened 9 years ago

nacho4d commented 9 years ago

Hello everyone. Thanks for this awesome library!

I got the latest version of nano and realized I was not able to update documents anymore when using some old code. I found there were some style changes in commit: 848caf7e7bf988fb19bd16143aa3e2b49470e28c that made the API not to work with old code

The exact change can be found here: https://github.com/dscape/nano/commit/848caf7e7bf988fb19bd16143aa3e2b49470e28c#commitcomment-11989091

I am not sure about the policy for addressing this kind of things. The commit is like 9 months old and since nobody else seems to have noticed this then I guess updating the documentation to highlight this kind of changes would be enough. Otherwise I can make I small pul request to support both :)

carlosduclos commented 7 years ago

This repository has been merged into couchdb-nano and this issue has been moved there. Please continue the discussion here.